Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: can diff side test points #382

Merged
merged 3 commits into from
Sep 21, 2024
Merged

Add: can diff side test points #382

merged 3 commits into from
Sep 21, 2024

Conversation

Suke0811
Copy link
Collaborator

Adding the testpoints for can diff side. The controller side is already in the lib.

ducky64
ducky64 requested changes Sep 21, 2024
View reviewed changes
Copy link
Collaborator

@ducky64 ducky64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block itself looks good. Though I think it also needs to be added to init.py?

@Suke0811
Copy link
Collaborator Author

Block itself looks good. Though I think it also needs to be added to init.py?

That's true, and I added it in init with 3b3a4fb

@ducky64 ducky64 merged commit b91e359 into master Sep 21, 2024
11 checks passed
@ducky64 ducky64 deleted the can_testpoint branch September 21, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducky64 ducky64 ducky64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Suke0811 @ducky64